Skip to content

[PM-27137] feat: Add credential deletion and debug info to Use Passkey screen - #2948

Draft
morganzellers-bw wants to merge 2 commits into
pm-27135-testharness-use-passkeys-uifrom
pm-27137-testharness-manage-debug-passkeys
Draft

[PM-27137] feat: Add credential deletion and debug info to Use Passkey screen#2948
morganzellers-bw wants to merge 2 commits into
pm-27135-testharness-use-passkeys-uifrom
pm-27137-testharness-manage-debug-passkeys

Conversation

@morganzellers-bw

@morganzellers-bw morganzellers-bw commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-27137

📔 Objective

Fourth and final PR in a 4-PR stack adding SDK-backed passkey test scenarios to TestHarness. Stacked on #2947.

  • Adds swipe-to-delete for registered credentials on the "Use Passkey (SDK)" screen, threaded through SDKFido2CredentialStore/SDKPasskeyService/SDKUsePasskeyProcessor.
  • Surfaces cipher ID, user handle, and signature-counter usage on each credential row for easier debugging.

📸 Screenshots

Stack: #2945 → #2946 → #2947 → #2948

@morganzellers-bw morganzellers-bw added the ai-review Request a Claude code review label Aug 7, 2026
This was referenced Aug 7, 2026
Open
Open
Open
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context t:feature labels Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the fourth and final PR in the SDK-passkey TestHarness stack, which adds swipe-to-delete for registered credentials on the "Use Passkey (SDK)" screen and surfaces cipher ID, user handle, and signature-counter usage on each credential row. Deletion threads consistently through DefaultFido2CredentialStore → DefaultPasskeyService → UsePasskeyProcessor, keeping the actor's in-memory cipher list and CipherStorageService persistence in sync, with new tests at the store, service, and processor layers covering both the success and throwing paths. The four new localization keys are unique in Localizable.strings and their Localizations accessors are SwiftGen-generated at build time (swiftgen-bwth.yml), while the Fido2CredentialAutofillView fixture already exposes the cipherId/hasCounter parameters the view and tests rely on. All changes stay inside the TestHarness target — an internal engineering harness backed by a synthetic identity — and touch no production Password Manager or Authenticator code.

Code Review Details

No findings met the confidence threshold for posting. The earlier test-seeding gap in UsePasskeyProcessorTests is resolved in e802917 — state.registeredCredentials is seeded before the delete effect and registeredCredentialsCalled is asserted, so the reload behavior is genuinely covered. Mock member names (deleteCredentialReceivedCipherId, deleteCredentialThrowableError) match what the AutoMockable stencil generates for a single-parameter throwing method.

  • ❓ QUESTION: The description notes screenshots of the new credential row layout and swipe action were not captured; worth adding before merge.

@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 06b4697 to df122c1 Compare August 7, 2026 21:56
@codecov

codecov Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.53%. Comparing base (42b2e54) to head (e802917).

Additional details and impacted files 
@@                           Coverage Diff                            @@
##           pm-27135-testharness-use-passkeys-ui    #2948      +/-   ##
========================================================================
+ Coverage                                 79.52%   79.53%   +0.01%     
========================================================================
  Files                                      1169     1169              
  Lines                                     75095    75095              
========================================================================
+ Hits                                      59720    59730      +10     
+ Misses                                    15375    15365      -10

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from df122c1 to ef4d0a2 Compare August 7, 2026 22:32
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from ef4d0a2 to aea0e5e Compare August 7, 2026 22:38
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from aea0e5e to dc0db85 Compare August 10, 2026 14:14
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from dc0db85 to 2ea47d2 Compare August 10, 2026 14:26
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 2ea47d2 to 33180e4 Compare August 10, 2026 14:55
@morganzellers-bw morganzellers-bw changed the title [PM-27137] feat: Add credential deletion and debug info to Use Passkey (SDK) screen [PM-27137] feat: Add credential deletion and debug info to Use Passkey screen Aug 10, 2026
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 33180e4 to f0b628f Compare August 10, 2026 17:01
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from f0b628f to dfce034 Compare August 10, 2026 18:46
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch 2 times, most recently from 45df9bd to 9464839 Compare August 12, 2026 19:16
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 21ed647 to f012bb6 Compare August 13, 2026 16:42
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from f012bb6 to a69cee8 Compare August 13, 2026 21:47
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from a69cee8 to f93256f Compare August 17, 2026 19:46
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from f93256f to 44ff45f Compare August 17, 2026 20:16
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 44ff45f to 015d4b8 Compare August 18, 2026 16:26
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 015d4b8 to eaf5cc2 Compare August 18, 2026 16:43
@morganzellers-bw morganzellers-bw mentioned this pull request Aug 18, 2026
Open
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from eaf5cc2 to a024c20 Compare August 18, 2026 17:21
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from a024c20 to 89abc71 Compare August 18, 2026 17:30
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 89abc71 to f52a1b8 Compare August 19, 2026 14:12
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from f52a1b8 to 30554fe Compare August 20, 2026 16:47
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 30554fe to 926175b Compare August 25, 2026 20:41
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 926175b to 58d5bf0 Compare August 26, 2026 19:08
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from 58d5bf0 to f7c97e9 Compare August 27, 2026 16:38
@morganzellers-bw
[PM-27137] feat: Add credential deletion and debug info to Use Passke…
524e81f 
…y screen

Adds swipe-to-delete for registered credentials, threaded through
DefaultFido2CredentialStore/PasskeyService/UsePasskeyProcessor, and
surfaces cipher ID, user handle, and signature-counter usage on each
credential row for easier debugging.
@morganzellers-bw
Updating test seeding.
e802917
@morganzellers-bw
morganzellers-bw force-pushed the pm-27137-testharness-manage-debug-passkeys branch from f7c97e9 to e802917 Compare August 27, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments
@matt-livefront matt-livefront Awaiting requested review from matt-livefront matt-livefront will be requested when the pull request is marked ready for review matt-livefront is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context t:feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@morganzellers-bw